lib: avoid unsafe array iteration in cli table - #65838
Open
HoonDongKang wants to merge 1 commit into
Open
Conversation
Avoid unsafe array iteration because for...of relies on the user-mutable Symbol.iterator. Use an index-based loop instead. Signed-off-by: HoonDongKang <d159123@naver.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65838 +/- ##
==========================================
+ Coverage 90.17% 90.18% +0.01%
==========================================
Files 770 771 +1
Lines 264483 264624 +141
Branches 50262 50230 -32
==========================================
+ Hits 238491 238646 +155
+ Misses 16981 16959 -22
- Partials 9011 9019 +8
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for...ofrelies on the user-mutableArray.prototype[Symbol.iterator], resulting in unsafe array iteration.This replaces it with an index-based loop when rendering table rows.
Refs
Tests:
./node test/parallel/test-console-table.js